T-compiler meeting agenda: add Zulip discussion links to MCPs and FCPs#1724
Merged
Mark-Simulacrum merged 3 commits intorust-lang:masterfrom Sep 29, 2023
Merged
Conversation
apiraino
commented
Sep 21, 2023
apiraino
commented
Sep 21, 2023
apiraino
commented
Sep 21, 2023
apiraino
commented
Sep 21, 2023
spastorino
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCPs and FCPs all have a corresponding Zulip chat link for discussion before being approved (or declined).
In order to facilitate reaching this discussion happening on Zulip, this patch retrieves the first comment of an MCP/FCP, parses the corresponding Zulip link and add it to the T-compiler agenda.
Example of how the list of MCP/FCP look before this patch:
Example of how the list of MCP/FCP look after this patch:
This idea was mentioned in a T-compiler meeting (on Zulip, of course).
Thanks for looking at this patch!
r? @spastorino